Skip to content

[elsa] fix(Observer): implement hierarchical observer notification system#169

Closed
RonnyChan96 wants to merge 1 commit intoModelEngine-Group:elsa-0.2.xfrom
RonnyChan96:elsa-0.2.x_fix_middle_layer_change_sub_node_observer_not_update_bug
Closed

[elsa] fix(Observer): implement hierarchical observer notification system#169
RonnyChan96 wants to merge 1 commit intoModelEngine-Group:elsa-0.2.xfrom
RonnyChan96:elsa-0.2.x_fix_middle_layer_change_sub_node_observer_not_update_bug

Conversation

@RonnyChan96
Copy link
Contributor

@RonnyChan96 RonnyChan96 commented Jun 17, 2025

Issue 链接 / Issue Link: #100

  • 我已经创建了相关 Issue 并进行了讨论 / I have created and discussed the related issue
  • 这是一个微小的修改(如错别字),不需要 Issue / This is a trivial change (like typo fix) that doesn't need an issue

📋 变更类型 / Type of Change

  • 🐛 Bug 修复 / Bug fix (non-breaking change which fixes an issue)
  • ✨ 新功能 / New feature (non-breaking change which adds functionality)
  • 💥 破坏性变更 / Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 文档更新 / Documentation update
  • 🔧 重构 / Refactoring (no functional changes)
  • ⚡ 性能优化 / Performance improvement
  • 🧹 代码清理 / Code cleanup

📝 变更目的 / Purpose of the Change

In the Reference path, when the referenceKey of a non-bottom-level node changes, the Reference data of the monitoring bottom-level node will not be updated, causing waterflow to be unable to find the correct Reference when consuming the data, resulting in the converted value being null.

📋 主要变更 / Brief Changelog

  • Add notifySubNodeObserver method for hierarchical notification propagation
  • Implement BFS-based observer notification through observable tree
  • Add adjacency list builder for efficient tree traversal
  • Integrate with existing emit/observer system
  • Support selective notification based on observer status

🧪 验证变更 / Verifying this Change

测试步骤 / Test Steps

  1. Create a code node, and the subsequent nodes reference the lowest level output of the code node (here this output needs to have an upper level modifiable output).
  2. Then modify the upper level output and observe whether the upper level key in the value data of the subsequent referenced nodes is updated.

测试覆盖 / Test Coverage

  • 我已经添加了单元测试 / I have added unit tests
  • 所有现有测试都通过 / All existing tests pass
  • 我已经进行了手动测试 / I have performed manual testing

📸 截图 / Screenshots

image

✅ 贡献者检查清单 / Contributor Checklist

请确保你的 Pull Request 符合以下要求 / Please ensure your Pull Request meets the following requirements:

基本要求 / Basic Requirements:

  • 确保有 GitHub Issue 对应这个变更(微小变更如错别字除外)/ Make sure there is a Github issue filed for the change (trivial changes like typos excluded)
  • 你的 Pull Request 只解决一个 Issue,没有包含其他不相关的变更 / Your PR addresses just this issue, without pulling in other changes - one PR resolves one issue
  • PR 中的每个 commit 都有有意义的主题行和描述 / Each commit in the PR has a meaningful subject line and body

代码质量 / Code Quality:

  • 我的代码遵循项目的代码规范 / My code follows the project's coding standards
  • 我已经进行了自我代码审查 / I have performed a self-review of my code
  • 我已经为复杂的代码添加了必要的注释 / I have commented my code, particularly in hard-to-understand areas

测试要求 / Testing Requirements:

  • 我已经编写了必要的单元测试来验证逻辑正确性 / I have written necessary unit-tests to verify the logic correction
  • 当存在跨模块依赖时,我尽量使用了 mock / I have used mocks when cross-module dependencies exist
  • 基础检查通过:mvn -B clean package -Dmaven.test.skip=true,elsa README 中的编译检查 / Basic checks pass
  • 单元测试通过:mvn clean install / Unit tests pass

文档和兼容性 / Documentation and Compatibility:

  • 我已经更新了相应的文档 / I have made corresponding changes to the documentation
  • 如果有破坏性变更,我已经在 PR 描述中详细说明 / If there are breaking changes, I have documented them in detail
  • 我已经考虑了向后兼容性 / I have considered backward compatibility

📋 附加信息 / Additional Notes


审查者注意事项 / Reviewer Notes:

@RonnyChan96 RonnyChan96 requested review from a team, CodeCasterX and wjn1584 June 17, 2025 08:58
@RonnyChan96 RonnyChan96 self-assigned this Jun 17, 2025
@RonnyChan96 RonnyChan96 added type: bug A general bug in: elsa Issues in Elsa modules labels Jun 17, 2025
@CodeCasterX CodeCasterX linked an issue Jun 17, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: elsa Issues in Elsa modules type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

现有的Observe机制,对于Path中间层级的变化未感知

1 participant